This is an old revision of the document!

Quick Search
Use native context menus on Mac OS
Categories
- (Core :: Widget: Cocoa, enhancement, P1)
Tracking
- (bug RESOLVED as FIXED)
People
- (Reporter: mpt, Assigned: mstange)
References
- (Depends on 6 open bugs, Blocks 3 open bugs)
Details
- (Keywords: helpwanted, platform-parity, Whiteboard: [proton-context-menus][mac:mr1])
Crash Data
Security
- (public)
User Story
Notes on customizability
Notes on "extra powers"
Notes on "special things"

Quick Search

<HTML><ul></HTML> <HTML><li></HTML>New Account<HTML></li></HTML> <HTML><li></HTML>Log In

or Remember Hello <HTML></li></HTML> <HTML><li></HTML>Forgot Password Hello <HTML></li></HTML><HTML></ul></HTML>

<div class="noscript"> <div class="inner"> <p>Please enable JavaScript in your browser to use all the features on this site.</p> </div> </div> Copy Summary

View ▾

Reset Sections
Expand All Sections
Collapse All Sections
History
JSON
XML

Closed Bug 34572 Opened 21 years ago Closed 28 days ago

Use native context menus on Mac OS

Summary:

Tracking

(bug RESOLVED as FIXED)

Status:

RESOLVED FIXED

Status:

RESOLVED

FIXED

Mark as Assigned

Milestone:

90 Branch

Iteration:

—

Project Flags:

Root Cause	—
a11y-review	—
Webcompat Priority	—
user-doc-firefox	—
Fission Milestone	—

Tracking Flags:

	Tracking	Status
thunderbird_esr78	—	wontfix
firefox-esr78	—	wontfix
firefox88	—	wontfix
firefox89	—	fixed
firefox90	—	fixed

	Tracking	Status
relnote-firefox		—
thunderbird_esr78	—	wontfix
firefox-esr78	—	wontfix
firefox88	—	wontfix
firefox89	—	fixed
firefox90	—	fixed

People

(Reporter: mpt, Assigned: mstange)

Assignee:

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=40 mstange

Assignee:

Reset Assignee to default

Mentors:

—

QA Contact:

Reset QA Contact to default

Reporter:

62844405c164de5fc2e38dad0af0c997?d=mm&size=40 mpt

Triage Owner:

24794cf906e308aee53a5173f6f1ed09?d=mm&size=40 spohl

CC:

61 people

References

(Depends on 6 open bugs, Blocks 3 open bugs)

Depends on:

1703518, 1705157, 1706966, 1680177, 1700706, 1700710, 1700713, 1700715, 1701085, 1701243, 1702041, 1703272, 1703482, 1703927, 1703930, 1704127, 1704474, 1704883, 1704972, 1705120, 1706433, 1707204, 1707652, 1707869, 1710507

[[show_bug.cgi?id=1700822|1700822]], [[show_bug.cgi?id=1702129|1702129]], [[show_bug.cgi?id=118025|118025]], [[show_bug.cgi?id=1692669|1692669]], [[show_bug.cgi?id=1700732|1700732]]

[[show_bug.cgi?id=1700727|1700727]], [[show_bug.cgi?id=1691213|1691213]], [[show_bug.cgi?id=1691861|1691861]], [[show_bug.cgi?id=1694853|1694853]], [[show_bug.cgi?id=1698662|1698662]], [[show_bug.cgi?id=1698668|1698668]], [[show_bug.cgi?id=1698997|1698997]], [[show_bug.cgi?id=1699551|1699551]], [[show_bug.cgi?id=1699582|1699582]], [[show_bug.cgi?id=1699792|1699792]], [[show_bug.cgi?id=1700679|1700679]], [[show_bug.cgi?id=1700724|1700724]], [[show_bug.cgi?id=1702387|1702387]], [[show_bug.cgi?id=1702633|1702633]], [[show_bug.cgi?id=1703617|1703617]], [[show_bug.cgi?id=1704102|1704102]]

Blocks:

1687055, 7297, 13185, 39403, macmeta

[[show_bug.cgi?id=1710459|1710459]]

[[show_bug.cgi?id=1681822|proton-context-menus]]

Dependency tree / graph

Regressions:

—

Regressed by:

—

Duplicates:

[[show_bug.cgi?id=37795|37795]], [[show_bug.cgi?id=196611|196611]], [[show_bug.cgi?id=239036|239036]], [[show_bug.cgi?id=240124|240124]], [[show_bug.cgi?id=1704306|1704306]]

URL:

Hello

Details

(Keywords: helpwanted, platform-parity, Whiteboard: [proton-context-menus][mac:mr1])

Alias:

—

Keywords:

helpwanted, platform-parity

Whiteboard:

[proton-context-menus][mac:mr1]

QA Whiteboard:

—

Has Regression Range:

—

Has STR:

—

Votes:

28

Bug Flags:

behind-pref	+ -
firefox-backlog
sec-bounty	?
sec-bounty-hof
in-qa-testsuite	? + -
in-testsuite	? + -
qe-verify

Crash Data

Signature:

Security

(public)

This bug is publicly visible.

User Story

Bottom ↓ Tags ▾

Reset

Timeline ▾

Reset
Collapse All
Expand All
Comments Only

62844405c164de5fc2e38dad0af0c997?d=mm&size=64	Matthew T (active 1999-2002) Reporter
	==== Description ==== • 21 years ago

Mozilla on MacOS is using native main menus -- the XUL menu items are being 
translated into native menu structures, allowing Mozilla to use the Mac's main 
menu bar.
 
Why couldn't this be done with context menus as well? As far as I know, Web apps 
don't have style access to (or even knowledge of) context menus, so the usual 
skinnability arguments are not an issue. Using native menus would improve 
internal consistency between Mozilla main menus and context menus (and between 
Mozilla and other MacOS apps), as well as solving quite a few open bugs about 
MacOS popup menus.
 
Implementing this could probably borrow heavily from the code already written for 
making the main Mac menus.

b9e23a7378deeb7b572e4b6153de010f?d=mm&size=64	Mike Pinkerton (not reading bugmail)
	==== Comment 1 ==== • 21 years ago

i can't argue, but it's a time thing.

Status: NEW → ASSIGNED

Keywords: helpwanted

Target Milestone: — → M20

8df6b95d9b2d093816c39f3fa65f7031?d=mm&size=64	sairuh (rarely reading bugmail)
	==== Comment 2 ==== • 21 years ago

*** Bug 37795 has been marked as a duplicate of this bug. ***

8df6b95d9b2d093816c39f3fa65f7031?d=mm&size=64	sairuh (rarely reading bugmail)
	==== Updated ==== • 21 years ago

Keywords: pp

0030426a5e04e85c33fe02480bc4ca81?d=mm&size=64	Henri Sivonen (:hsivonen)
	==== Updated ==== • 21 years ago

Blocks: 39375

62844405c164de5fc2e38dad0af0c997?d=mm&size=64	Matthew T (active 1999-2002) Reporter
	==== Updated ==== • 21 years ago

Blocks: 39403

62844405c164de5fc2e38dad0af0c997?d=mm&size=64	Matthew T (active 1999-2002) Reporter
	==== Updated ==== • 21 years ago

No longer blocks: 39375

948203838a39d11455eeee5c04c95104?d=mm&size=64	Peter Trudelle
	==== Comment 3 ==== • 21 years ago

Mass-moving all M20-M30 XPToolkit bugs to Future

Target Milestone: M20 → Future

8df6b95d9b2d093816c39f3fa65f7031?d=mm&size=64	sairuh (rarely reading bugmail)
	==== Comment 4 ==== • 21 years ago

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

QA Contact: sairuh → jrgm

62844405c164de5fc2e38dad0af0c997?d=mm&size=64	Matthew T (active 1999-2002) Reporter
	==== Updated ==== • 21 years ago

Blocks: 7297

9ca235474c2f65fb9c1fd42a2e2e5ef6?d=mm&size=64	Blake Ross
	==== Comment 5 ==== • 21 years ago

How easy/hard would this be?

f12af0ce23cd6483cb6ae398e0578bc6?d=mm&size=64	akt
	==== Comment 6 ==== • 21 years ago

I believe the following behavior is caused by this bug:
 
I have to "Turn off Contextual Menus in Mozilla 0.7" to see Mozilla's contextual
menus -- otherwise I get the "default" MacOS contextual menu (Help, Application
Menu, Refresh menus)

62844405c164de5fc2e38dad0af0c997?d=mm&size=64	Matthew T (active 1999-2002) Reporter
	==== Updated ==== • 21 years ago

Severity: normal → enhancement

OS: All → Mac System 8.5

Summary: Use native context menus on MacOS → Use native context menus on Mac OS

318c9995a7701be352479946a3b3aac0?d=mm&size=64	Matt Lee
	==== Comment 7 ==== • 21 years ago

The behavior being described by akt@yahoo.com above is caused actually by Apple
Data Detectors, an old software set that used AppleScript to open URLs embedded
in plain text. Its special contextual menus are available in all applications by
default, and you have to manually turn it off in apps that you don't want. It's
not relevant to this bug, as far as I can tell. (While I'm here, I'd like to
throw in my support for using the Mac's native menus.)

affe24e082dc08f09d52df6d91182add?d=mm&size=64	Andrew Thompson
	==== Updated ==== • 21 years ago

Blocks: 13185

affe24e082dc08f09d52df6d91182add?d=mm&size=64	Andrew Thompson
	==== Updated ==== • 21 years ago

No longer blocks: 13185

17d2e210830d33d6d8eae597fd189975?d=mm&size=64	nnooiissee
	==== Comment 8 ==== • 20 years ago

just make sure the native menus still come up if the contextual menus extension
is not pressent. i for one loath that damnable thing--apple decided to wipe out
control key alias dragging, okay that was defacto, but not official, but
removing command-option dragging to copy and align? that dated back as far as i
have used mac os.
 
not that we needed contextual menus, mind you. oh well, maybe someday someone
will do something useful with them (rather than converting a working system,
xul, in a way that might break it (maybe this bug should at least depend on bug
51142).

f11baed4412ff009043440f29cb52127?d=mm&size=64	m_mozilla
	==== Comment 9 ==== • 20 years ago

does this block bug 13185 ?
 
-matt

0030426a5e04e85c33fe02480bc4ca81?d=mm&size=64	Henri Sivonen (:hsivonen)
	==== Updated ==== • 20 years ago

Blocks: 13185

8393b8cb5ce8371dcfe93f5d4f76e90a?d=mm&size=64	Hixie (not reading bugmail)
	==== Updated ==== • 20 years ago

Depends on: 118025

8393b8cb5ce8371dcfe93f5d4f76e90a?d=mm&size=64	Hixie (not reading bugmail)
	==== Updated ==== • 20 years ago

Depends on: 118296

8393b8cb5ce8371dcfe93f5d4f76e90a?d=mm&size=64	Hixie (not reading bugmail)
	==== Updated ==== • 20 years ago

No longer depends on: 118296

96fd6f4f3138076526f581804847a4be?d=mm&size=64	Frankie
	==== Comment 10 ==== • 19 years ago

Does this bug affect OS X? If not, it should be WONTFIX.

0e80b75d0dd2dbbaeb0c65a006e926e3?d=mm&size=64	Chibi15
	==== Comment 11 ==== • 19 years ago

It does affect Mac OS X.

dd45b9f6f663a1a2e85983c1f2cf5792?d=mm&size=64	Jo Hermans
	==== Comment 12 ==== • 19 years ago

*** Bug 196611 has been marked as a duplicate of this bug. ***

96fd6f4f3138076526f581804847a4be?d=mm&size=64	Frankie
	==== Updated ==== • 19 years ago

OS: Mac System 8.5 → MacOS X

fed88e8dc2798851fdee8bf9c80b8e91?d=mm&size=64	David Douthitt
	==== Comment 13 ==== • 18 years ago

Not having standard MacOS contextual menus means that Chronos Software's
StickyBrain does not function with Mozilla at all, and thus significantly
affects the user's ability to use StickyBrain for its intended purpose.
 
Mozilla also needs to recognize AppleScript (I know Camino doesn't...)

de8abfa9de1d36b01d556a823dc11112?d=mm&size=64	Simon Fraser [no longer active]
	==== Comment 14 ==== • 18 years ago

> Mozilla also needs to recognize AppleScript (I know Camino doesn't...)
 
Sure they do. There isn't much support, but there's some. What do you need?

530dbb5f69c5b50a70452097c4ed71e2?d=mm&size=64	Greg K.
	==== Comment 15 ==== • 17 years ago

*** Bug 240124 has been marked as a duplicate of this bug. ***

da15acc10df24dd1d172935e9d68b64d?d=mm&size=64	Mano (::mano, needinfo? for any questions; not reading general bugmail)
	==== Updated ==== • 17 years ago

Flags: blocking-aviary1.0mac?

50d741a686db0a80b1d27e90dc33efc4?d=mm&size=64	Kevin Gerich
	==== Comment 16 ==== • 17 years ago

*** Bug 239036 has been marked as a duplicate of this bug. ***

da15acc10df24dd1d172935e9d68b64d?d=mm&size=64	Mano (::mano, needinfo? for any questions; not reading general bugmail)
	==== Updated ==== • 17 years ago

Flags: blocking-aviary1.0mac?

ea49fc4f8a9c515e4d12d995a9d7a861?d=mm&size=64	louis bennett
	==== Updated ==== • 17 years ago

Blocks: 262956

ea49fc4f8a9c515e4d12d995a9d7a861?d=mm&size=64	louis bennett
	==== Updated ==== • 17 years ago

Blocks: 101472
No longer blocks: 262956

da15acc10df24dd1d172935e9d68b64d?d=mm&size=64	Mano (::mano, needinfo? for any questions; not reading general bugmail)
	==== Updated ==== • 17 years ago

Blocks: macmeta

da15acc10df24dd1d172935e9d68b64d?d=mm&size=64	Mano (::mano, needinfo? for any questions; not reading general bugmail)
	==== Comment 17 ==== • 17 years ago

I've started to work on this..
 
So far, i have an issue: DrawThemeMenuItem needs the menu rect (in addition to
the menuitem rect); how can i achieve it?

6ae2977f102dcb8c9c9c57c0fcf13292?d=mm&size=64	David Catmull
	==== Comment 18 ==== • 17 years ago

I bet you can get away with using the same rect for both. I suspect OS 9's
beveled edges were mainly what made this important.

da15acc10df24dd1d172935e9d68b64d?d=mm&size=64	Mano (::mano, needinfo? for any questions; not reading general bugmail)
	==== Comment 19 ==== • 17 years ago

(In reply to comment #18)
> I bet you can get away with using the same rect for both. I suspect OS 9's
> beveled edges were mainly what made this important.
 
Probably not, even HITheme api (10.3+) thinks it needs this information.

722a51b7f4de7ea635db1c9cb0a7dc80?d=mm&size=64	Ben Fowler
	==== Comment 20 ==== • 17 years ago

(In reply to comment #17)
> I've started to work on this..
 
This report is marked as HELPWANTED . Do you have any design documentation?
Is there any way to speed your efforts on this 5 year old bug?

a8fc05fdb6f74856d2cfbeef69fcda2a?d=mm&size=64	Josh Aas
	==== Updated ==== • 16 years ago

Assignee: mikepinkerton → joshmoz

Status: ASSIGNED → NEW

a8fc05fdb6f74856d2cfbeef69fcda2a?d=mm&size=64	Josh Aas
	==== Updated ==== • 14 years ago

Assignee: joshmoz → nobody

e4a0566b254d665aa267b7874726fbbf?d=mm&size=64	timeless
	==== Updated ==== • 13 years ago

Component: XP Toolkit/Widgets: Menus → XUL

QA Contact: jrgmorrison → xptoolkit.widgets

89db5ccbe71d2e916c218c85076fbd96?d=mm&size=64	Florian Bender
	==== Comment 21 ==== • 8 years ago

Fixing this should fix quite a few other bugs, including future OS style changes, so yes please! 
 
This bug should block Bug 565518.

	Jim Mathies [:jimm]
	==== Updated ==== • 5 years ago

No longer blocks: 101472

1d91d22a4892f16f744b31fd4286144e?d=mm&size=64	Emilio Cobos Álvarez (:emilio)
	==== Updated ==== • 2 years ago

Component: XUL → Widget: Cocoa

Hardware: PowerPC → All

6620d37f4370beced1bed4097c36d249?d=mm&size=64	Haik Aftandilian [:haik]
	==== Updated ==== • 8 months ago

Notes on customizability

Native menus allow for a certain degree of customization by the app, via custom NSViews that are shown instead of menu items. So that means, for each horizontal row in a menu, we have the choice between two options:

A native menu item, which can have a label, an icon, a checkmark, a submenu, and a shortcut key annotation. These menu items are displayed with the native style for the OS. Their styling cannot be customized, but we also do not need to maintain them because they automatically adopt the updated look of any new macOS versions. (Edit: As noted by Ken below, it is possible to set custom text styling by using an NSAttributedString as the label.)
Or a custom view. These views occupy the full width of the menu, and a custom height. They can have arbitrary content and user input handling. Any text styling, hover effects, click handling, flashing effects etc needs to be implemented manually. If there are visual elements in custom views that are intended to match the OS native look, then the code for these visual elements needs to be updated whenever a new macOS version with an updated look is released.

Notes on "extra powers"

I'm aware of three features our fake menus have, which I don't think we can replicate in native menus:

Handling of arbitrary modifier keys when clicking menu items: For example, if you click a bookmarks folder in the Bookmarks toolbar to display the folder contents in a menu, and then hold the Cmd key while clicking a bookmark item, the item will load in a new tab. If you try the same in a native menu, for example in the Bookmarks menu from the menubar, then the Cmd key is ignored and the clicked bookmark will open in the current tab. Edit: This appears to be wrong, see the comments below. It looks like we can handle arbitrary modifier keys on native menu items.
"Menus on menus": For example, if you click a bookmarks folder in the Bookmarks toolbar, and then right-click a bookmark in the menu, you get a context menu that is displayed on top of the bookmarks folder popup. This is not possible with native menus - you cannot stack native menus, and you cannot right-click native menu items. (Or rather, right-clicking a native menu item will activate that item.)
Drag and drop of menu items: In bookmarks folder menus from the Bookmarks Toolbar, you can move and reorder bookmarks using drag and drop, even across different folders and submenus. This is not possible in native menus.

For these reasons, I think we should keep using custom menus for bookmarks folders in the Bookmarks Toolbar. We may want to update their styling to be explicitly different from native menus, so that users can have the right expectations for what they can do with them.
Also, for right-click context menus inside the custom bookmark folder menus, we can definitely use a native menu for the context menu.
As an alternative, we could decide to drop all this extra functionality on macOS. For example, Safari doesn't let you do any of the abovementioned things in their bookmarks toolbar.

Notes on "special things"

Most of our context menus only use basic menu elements and should easily work as native menus. However, we would need custom NSView implementations for the following:

For context menus:
- The main content area context menu has a row at the top that shows four big icons: back, forward, refresh, bookmark. If we want to keep this custom icon row, we cannot use native menu items for these buttons, but we can implement the icon row with a custom view. This will require manually handling hover effects (including OS-specific visual styling of those hover effects) and click handling, including the flashing animation when an icon is clicked. The rest of the menu can be standard menu items.
For <select> popups:
- If we decide to use native menus for <select> popups, we will probably need custom views for <optgroup> headers, and for items with custom styling (fonts, font styles, text color, background color). It's worth looking at Chrome's code for this (I haven't done that yet).
For bookmark folders from the bookmarks toolbar:
- If we really want to use native menus for them, and keep their current feature set, then we'd need to do a ton of custom work here. I recommend against it. Let's keep using fake menus for them for now.

affe24e082dc08f09d52df6d91182add?d=mm&size=64	Andrew Thompson
	==== Comment 23 ==== • 6 months ago

Excellent analysis. One comment:

“ If you try the same in a native menu, for example in the Bookmarks menu from the menubar, then the Cmd key is ignored and the clicked bookmark will open in the current tab.”

There is definitely some support for holding modifiers in native menus in the main menu bar at least. E.g. go to the Finder and open the File menu, then hold down Control, Option or Shift and observe the menu items change.

Is it possible that the issue here is more specific? That you can’t hold down Cmd and get a different behavior?
Maybe the simpler fix there is to map the behavior to Opt rather than Cmd (that’s the key I would expect to use to modify behavior).

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 24 ==== • 6 months ago

(In reply to Andrew Thompson from comment #23)

Maybe the simpler fix there is to map the behavior to Opt rather than Cmd (that’s the key I would expect to use to modify behavior).

That definitely sounds like a good option to consider!

063728cf137e95d95869aea2b70e31a3?d=mm&size=64	Ken Harris
	==== Comment 25 ==== • 6 months ago

Markus, that's a great start. A couple thoughts (as a Mac developer who has fought with custom menus before):

You can handle modifier keys from stock menu items. I think Firefox should be improved to support cmd=newtab in the menu bar Bookmarks menu, as you suggest. Safari, in fact, supports exactly that feature! No need for custom menu items here, thankfully.
"Menus on menus" is such a strange interaction I wasn't aware Firefox did this. I tried it just now, and it's broken in several ways: the drawing is wrong, the mouse handling is wrong, and even keyboard shortcuts light up (but don't do anything) when it's open. It's downright hard to highlight or choose a menu item here just using the mouse normally. I've never seen any other Mac application have "menus on menus", and it breaks one of the most common standard menu operations (to be able to right-click on a menu item to choose it), so I would not be at all sad to see this removed.

Still, I do see value in being able to see a bookmark in a menu and go directly to editing it, if a more Mac-like way could be found. A common method I tend to see for "show me this in context" is holding down command while choosing a menu item (e.g., holding command while selecting an app from a folder's menu in the dock shows that app in the Finder rather than launching it), but unfortunately "command" is already used for "open in new tab". (Maybe "option"? In Safari, option always means "download", but it seems to be unused in Firefox. I don't know what the overall design for modifier keys in Firefox is.)

It's true that if you use a custom NSView, you take on responsibility for all drawing and event handling, which is a pain. In my own application, I took a middle path: NSMenuItem has an "attributedTitle" property for using an NSAttributedString as its label. This makes it easy to make an ordinary menu item with a special font, or even insert images (with transparency) in the middle of the text. It's much easier than a custom NSView, as you don't have to re-implement all of the event handling by hand, or do extra work each year to support OS visual upgrades.

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 26 ==== • 6 months ago

That's awesome feedback, thanks a lot!

97a59b1c1ea99dbc4db5a0452b6ae78e?d=mm&size=64	marczellm
	==== Comment 27 ==== • 6 months ago

Let me provide an opposing perspective: as a heavily cross-platform user across Mac, Windows and sometimes even Linux, I'd be annoyed if the bookmarks toolbar supported different subsets of features on different platforms. Right clicking on a bookmark anywhere and having the same context menu actions on it is the most natural thing to me and I wouldn't like it taken away.

90d81da98d5b5e40bfa1ebe891438f8f?d=mm&size=64	Michal Jakubowski
	==== Comment 28 ==== • 6 months ago

I'm a multiplatform guy (using Windows PC and MacBook Air with macOS daily) and for me more annoying is having ugly context menu that does not fit to the OS (and now even more annoying, one that does not support dark mode).

7df2bf03204be8ae8868e4ce480fb9c8?d=mm&size=64	Cam
	==== Comment 29 ==== • 6 months ago

If we get native context menus, I very much hope to be given the option to deny extensions access to the context menu. As is I have to use the following to be able to maintain a sane context menu.

#context-media-eme-learnmore + menuseparator,
#context-media-eme-learnmore + menuseparator ~ *,
 {
     display: none !important;
 }

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 30 ==== • 6 months ago

All right folks, let’s keep the rest of this bug focused on the implementation. The first step will only be about context menus anyway, and no loss of functionality is expected. If we do decide to change anything about the bookmarks toolbar folder implementation, it will happen later and in a different bug. I will link to that bug here once we get to that stage. No more advocacy comments please.
As for the add-on entries in context menu issue, yes, the userChrome CSS workaround from comment 29 will probably not work on native context menus. We can file a new bug to determine whether that’s something we want to support.

66445733c06687eafa2978764675104f?d=mm&size=64	:Gijs (he/him)
	==== Updated ==== • 5 months ago

Blocks: proton-context-menus

66445733c06687eafa2978764675104f?d=mm&size=64	:Gijs (he/him)
	==== Updated ==== • 5 months ago

Whiteboard: [proton-contextmenu]

a4fb6ffb38387ae4ee8a8c098330948e?d=mm&size=64	Blake Winton (:bwinton) (:☕️)
	==== Updated ==== • 5 months ago

Whiteboard: [proton-contextmenu] → [proton-context-menus]

8363992a22cf569ed04b49ae96310c2d?d=mm&size=64	Mike Schreiber
	==== Comment 31 ==== • 5 months ago

I'm pulling the Firefox source code now to look into this, but would it make more sense for us to consider Photon-themed context menus instead of going the native AppKit route? Greater UI consistency within the app seems like an admirable goal, and it'd give us flexibility to more easily incorporate nonstandard components like the forward/back/bookmark controls, as well as the userChrome CSS workaround from comment 29.

a4fb6ffb38387ae4ee8a8c098330948e?d=mm&size=64	Blake Winton (:bwinton) (:☕️)
	==== Comment 32 ==== • 4 months ago

Hi Mike! We have considered it, but decided to go with native context menus on MacOS. (I don't have the full justification, but to me they just feel more like a thing that should be native… :)

Thanks for the comment!

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 33 ==== • 4 months ago

I'm starting to work on this now.

Quick status update:

For now, only context menus will become native.
Bookmark folder dropdowns will be styled in a Firefox-specific (non-native) way and retain their full functionality. This was decided with the involvement of the UX team.
<select> popups may become native at some point in the future but will stay non-native for now.

Assignee: nobody → mstange.moz

Status: NEW → ASSIGNED

Target Milestone: Future → —

9a3dfe5bbf80520b067e6c33e692dc99?d=mm&size=64	Julien Chaupitre
	==== Updated ==== • 4 months ago

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 4 months ago

Depends on: 1691213

9a3dfe5bbf80520b067e6c33e692dc99?d=mm&size=64	Julien Chaupitre
	==== Updated ==== • 4 months ago

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 3 months ago

Depends on: 1691861

66445733c06687eafa2978764675104f?d=mm&size=64	:Gijs (he/him)
	==== Updated ==== • 3 months ago

Depends on: 1692669

5b61cf6eac8fafed30b181b20145dad8?d=mm&size=64	Martin Balfanz [:mbalfanz]
	==== Updated ==== • 3 months ago

Whiteboard: [proton-context-menus] → [proton-context-menus][mac:mr1]

0ab3c6408e2ba9a00a4f48d50696d4dd?d=mm&size=64	Eiichi
	==== Comment 34 ==== • 3 months ago

Regarding <select>, please see also the bug 1571386.

a4fb6ffb38387ae4ee8a8c098330948e?d=mm&size=64	Blake Winton (:bwinton) (:☕️)
	==== Comment 35 ==== • 3 months ago

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Priority: P3 → P1

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 3 months ago

Depends on: 1694853

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1698662

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1698668

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1698997

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1699551

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1699582

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1699792

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1680177

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700679

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700706

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700710

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700713

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700715

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700724

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700727

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700732

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1700822

4f06b4506694363ff946272a673321ae?d=mm&size=64	Sören Hentzschel
	==== Updated ==== • 2 months ago

Depends on: 1701085

4f06b4506694363ff946272a673321ae?d=mm&size=64	Sören Hentzschel
	==== Updated ==== • 2 months ago

Depends on: 1701243

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1702041

5b61cf6eac8fafed30b181b20145dad8?d=mm&size=64	Martin Balfanz [:mbalfanz]
	==== Updated ==== • 2 months ago

Depends on: 1702129

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 2 months ago

Depends on: 1702288

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

No longer depends on: 1702288

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1702387

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1702633

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1702664

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 36 ==== • 2 months ago

Native context menus are now ready for testing on Nightly; all known bugs are fixed. To enable native context menus on Nightly, set these two prefs to true: widget.macos.native-context-menus and browser.proton.enabled

Please file any bugs you find in the Widget:Cocoa component and make them block this bug.

Thanks!

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 2 months ago

Depends on: 1703272

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 2 months ago

Depends on: 1703482

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1703617

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1703927

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1703930

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 2 months ago

Depends on: 1704127

24794cf906e308aee53a5173f6f1ed09?d=mm&size=64	Stephen A Pohl [:spohl]
	==== Updated ==== • 2 months ago

Duplicate of this bug: 1704306

0d674a646529b0795088d7a8075fbaea?d=mm&size=64	Marco Bonardo [:mak]
	==== Updated ==== • 1 month ago

Depends on: 1704474

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

Depends on: 1703518

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

Depends on: 1704883

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

Depends on: 1704972

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 1 month ago

Depends on: 1705157

63122a42678625e002461fb6bc287069?d=mm&size=64	Harry Twyford [:harry]
	==== Updated ==== • 1 month ago

Blocks: 1687055

9a3dfe5bbf80520b067e6c33e692dc99?d=mm&size=64	Julien Chaupitre
	==== Updated ==== • 1 month ago

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

Depends on: 1706433

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 1 month ago

Depends on: 1706966

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

No longer depends on: 1702664

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 1 month ago

Depends on: 1705120

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 29 days ago

Depends on: 1707204

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 29 days ago

Depends on: 1707652

8641c9f2c9af8263df2208974cf26aab?d=mm&size=64	Emil Ghitta, QA [:emilghitta]
	==== Updated ==== • 28 days ago

Depends on: 1707869

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 38 ==== • 28 days ago

Bug 1700679 enabled native context menus by default on Nightly (Firefox 90), so this bug is now fixed!

Status: ASSIGNED → RESOLVED

Closed: 28 days ago

status-firefox88: — → wontfix

status-firefox89: — → affected

status-firefox90: — → fixed

status-firefox-esr78: — → wontfix

status-thunderbird_esr78: — → wontfix

Resolution: — → FIXED

Target Milestone: — → 90 Branch

121e5db005ab2dcda847d6f162d42b69?d=mm&size=64	Mehmet
	==== Comment 39 ==== • 27 days ago
obsolete

Comment hidden (obsolete)

Can you please link Bug 1708017 to this one? Thanks :)

adb9cc17930b20ab1162918d97b755c9?d=mm&size=64	Albert Scheiner [:alberts]
	==== Comment 40 ==== • 27 days ago

👏👏👏

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 26 days ago

Depends on: 1704102

5293fe8fb106a442d842757758d07c56?d=mm&size=64	Pascal Chevrel:pascalc
	==== Comment 41 ==== • 21 days ago

Fixed by uplift in 89 beta 8

status-firefox89: affected → fixed

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 15 days ago

Blocks: 1710459

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 14 days ago

Depends on: 1710507

121e5db005ab2dcda847d6f162d42b69?d=mm&size=64	Mehmet
	==== Updated ==== • 14 days ago

Depends on: 1710583

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Updated ==== • 13 days ago

No longer depends on: 1710583

You need to log in before you can comment on or make changes to this bug.

Top ↑

dcai

Table of Contents

Quick Search

Use native context menus on Mac OS

Categories

(Core :: Widget: Cocoa, enhancement, P1)

Tracking

(bug RESOLVED as FIXED)

People

(Reporter: mpt, Assigned: mstange)

References

(Depends on 6 open bugs, Blocks 3 open bugs)

Details

(Keywords: helpwanted, platform-parity, Whiteboard: [proton-context-menus][mac:mr1])

Crash Data

Security

(public)

User Story

Notes on customizability

Notes on "extra powers"

Notes on "special things"

711e7c6f7c2c62a7bc2eb760585c3daa?d=mm&size=64	Markus Stange [:mstange] Assignee
	==== Comment 22 ==== • 6 months ago • Edited

.cls-1{fill:#93c7ef;}dcai

Site Tools

Table of Contents

Quick Search

Use native context menus on Mac OS

Categories

(Core :: Widget: Cocoa, enhancement, P1)

Tracking

(bug RESOLVED as FIXED)

People

(Reporter: mpt, Assigned: mstange)

References

(Depends on 6 open bugs, Blocks 3 open bugs)

Details

(Keywords: helpwanted, platform-parity, Whiteboard: [proton-context-menus][mac:mr1])

Crash Data

Security

(public)

User Story

Notes on customizability

Notes on "extra powers"

Notes on "special things"

Page Tools

User Tools

dcai